Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-1711] Add Docker image for bws versioning for release workflow #573

Merged
merged 5 commits into from
Feb 6, 2024
Merged

[DEVOPS-1711] Add Docker image for bws versioning for release workflow #573

merged 5 commits into from
Feb 6, 2024

Conversation

michalchecinski
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add docker publish to release-cli.yml workflow.

Code changes

  • .github/workflows/release-cli.yml: Add docker publish job to release-cli.yml workflow.
  • .github/workflows/build-cli-docker.yml Remove unused input. Publish docker only if building for publish branch

Before you submit

  • Please add unit tests where it makes sense to do so

@michalchecinski michalchecinski requested a review from a team as a code owner February 2, 2024 12:46
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 2, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 80560829-150b-4ca6-b88c-be7ccea92c04

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 146 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 70 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 63 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 213 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 151
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 75
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 68

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac58ac9) 53.36% compared to head (7b9ff12) 53.77%.
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   53.36%   53.77%   +0.41%     
==========================================
  Files         165      165              
  Lines        8772     8878     +106     
==========================================
+ Hits         4681     4774      +93     
- Misses       4091     4104      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vgrassia
vgrassia requested changes Feb 5, 2024
View reviewed changes
.github/workflows/release-cli.yml Outdated Show resolved Hide resolved
.github/workflows/release-cli.yml Outdated Show resolved Hide resolved
.github/workflows/release-cli.yml Outdated Show resolved Hide resolved
michalchecinski and others added 3 commits February 5, 2024 16:45
@michalchecinski @vgrassia
Update .github/workflows/release-cli.yml
7b0a397 
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@michalchecinski @vgrassia
Update .github/workflows/release-cli.yml
73ec384 
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@michalchecinski @vgrassia
Update .github/workflows/release-cli.yml
7b9ff12 
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@michalchecinski michalchecinski merged commit 1595306 into main Feb 6, 2024
60 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1711-Add-Docker-image-for-bws-versioning-for-release-workflow branch February 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangowithfoxtrot tangowithfoxtrot tangowithfoxtrot approved these changes

@vgrassia vgrassia vgrassia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalchecinski @bitwarden-bot @vgrassia @tangowithfoxtrot